[3.0.0-beta-2] Animations disappear when re-signing SVG code signatures or renaming selectors

markballard · January 7, 2025, 6:59pm

If I make changes to SVG elements using the code editor and re-sign the code signature, all the animations completely disappear from the animation panel and I have to start from scratch. If I manually enter in a target selector the panel flashes. The builder also becomes unresponsive intermittently with the panel open and is just really glitchy. In some cases the gray bar that I guess is supposed to be used resize the panel has a gap. I didn’t notice this issue when I was playing around with SVG animation in beta 1. I think it might be related to morph SVG since I get these console errors in the builder:

GSAP target [object NodeList] not found. https://greensock.com
p @ gsap.min.js?ver=1735314553:2

Uncaught TypeError: Cannot read properties of null (reading ‘clientHeight’)
at builder.js?ver=1735314553:1:211429

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading ‘morphSVG’)
at bricksforge_panel.js?ver=1735314553:1:62800
at Array.forEach ()
at Proxy.handleTimeline (bricksforge_panel.js?ver=1735314553:1:54925)
at Proxy.renderPanel (bricksforge_panel.js?ver=1735314553:1:7436)
at builder.js?ver=1735314553:1:202126
at new Promise ()
at Pe (builder.js?ver=1735314553:1:202095)
at builder.js?ver=1735314553:1:211772
at vendors.js?ver=1735314553:2:83840
at s (vendors.js?ver=1735314553:2:65419)

Daniele · January 11, 2025, 10:19am

Hmm… possible you are using the “Render without wrapper” function? If so, the element ID of the code element will not be present, as Bricks entirely ignores to render it, which is fine in this context.

I can confirm the problematic after changing selectors. Will try to find a solution here which I add to the next beta.

Regarding the lag: could you send me some steps to reproduce it? For me, after trying different things, also with SVGs, it runs permanently smooth.

Thank you!

markballard · January 11, 2025, 4:59pm

The SVG element doesn’t have a render without wrapper toggle so I don’t think it’s that. But this is likely not an SVG issue anyway since others experienced this without SVG. It just happened to me when I was playing with SVG so thought that might be the cause. The unresponsiveness issue was likely due to the GSAP timeline sync issue that you marked as fixed. I’ll let you know if it happens again in beta 3.